The Art of Saying "No" in Code Review

The provided text outlines a structured approach to giving feedback during code reviews, categorizing comments into different levels of severity and formality. Here's a summary and cheat sheet based on the information:

Summary

1. Level 0 (Positive Feedback): Use when you want to acknowledge something that is good or well-implemented.

   • Example: "Nice — this handles..."

2. Level 1 (Nit): Minor suggestions for improvement, which can be ignored if not relevant.

   • Prefix: Nit:
   • Example: "Nit: maybe X instead of Y?"

3. Level 2 (Suggestion): Suggesting an alternative approach or implementation that could improve the code but is not critical.

   • Prefix: Suggestion: / Consider... / Another option:
   • Example: "Consider using parameterized queries."

4. Level 3 (Question): Asking for clarification or seeking to understand a specific part of the code better.

   • No prefix needed, just ask questions like:
     • "What is the purpose of this?"
     • "Why did you choose X over Y?"

5. Level 4 (Concern): Indicating

Read the full article at DEV Community

---

Want to create content about this topic? Use Nemati AI tools to generate articles, social posts, and more.